evals / account-service
valid-name-change
Expected
Hidden from the reviewer, like the grading note below.
- ownership
- holds
- database-failures
- holds
- transaction-effects
- holds
Whitespace normalization should preserve ownership, database failure propagation, and transaction ordering. An unchanged guarantee need not be re-established as though the baseline were unknown. Assess all three contracts; catching no target defect does not excuse an unsupported finding elsewhere.
Change
src/service.py
-1+1
5 unmodified lines67899105 unmodified lines if account is None: raise PermissionError("Account unavailable") async with db.transaction(): await db.accounts.rename(account_id, name) await db.accounts.rename(account_id, name.strip()) await events.publish("account.updated", {"id": account_id})Contracts
ownership
---
name: ownership
message: Only update accounts owned by the caller.
---
## Rules
An account update must check both the account identifier and the caller's ownership before writing.
Missing or unauthorized accounts must not reach the write. Ownership checks may live in a helper.
## Checks
Follow the update path and its database query. An account identifier alone is not authorization.
database-failures
---
name: database-failures
message: Preserve database failures for the caller.
---
## Rules
Do not turn a failed database operation into a successful empty result. Propagating or translating
an error into another error is fine. Logging alone does not preserve failure.
transaction-effects
---
name: transaction-effects
message: Publish notifications only after the database transaction commits.
---
## Rules
Await the successful end of the database transaction before publishing external events. A failed
transaction must not publish a notification. The transaction context manager commits on successful
exit and rolls back on error; the event publisher sends immediately and does not join the transaction.