evals / debt-shop
sku-prefix-helper
Expected
Hidden from the reviewer, like the grading note below.
- no-swallowed-errors
- holds
A pure sku_prefix function is added to catalog.py. It has no try or except, and parse_price's existing handler is unchanged. The contract holds for this change.
Change
shop/catalog.py
+4
28 unmodified lines2930313233343528 unmodified linesdef catalog_size(path: Path) -> int: with path.open() as handle: return sum(1 for _ in csv.DictReader(handle))
def sku_prefix(sku: str) -> str: return sku.split("-", 1)[0]Contracts
no-swallowed-errors
---
name: no-swallowed-errors
message: Let errors crash; never catch an exception to hide it.
---
## Rules
Python code under `shop/` must not suppress exceptions.
Every `except` block must re-raise the exception or raise another exception, for example `raise BadRequest(...) from err`.
An `except` block that returns a value, returns `None`, uses `pass` or `continue`, or only logs is forbidden.
`contextlib.suppress` is forbidden for the same reason.
`try/finally` used only for cleanup, such as closing a file, is allowed.